Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does react-native-todo-list need updating? #1499

Open
doelgonzo opened this issue Feb 29, 2024 · 0 comments
Open

Does react-native-todo-list need updating? #1499

doelgonzo opened this issue Feb 29, 2024 · 0 comments
Labels
bug Something isn't working experience

Comments

@doelgonzo
Copy link

Describe the bug

Checking out the react-native example, I tried pulling it down on my Mac but my mac version required I use iOS 12+, so I simply copied the config and modeled my app to follow the patterns in the example. However, I ran into errors around window.postMessage and window.addEventListener being undefined. I mocked those, and it seems like the errors no longer happen, but (1) the docs don't capture that, and (2) It's unclear if setting this will affect functionality at all (even though it seems like the example works.

Now, my example uses the latest react-native version (0.73.5), so I don't know if that has anything to do with needing to stub out those window functions, as the example doesn't stub them out. Should this be the new way of doing it?

To Reproduce

Steps to reproduce the behavior:

  1. Download example repo
  2. Cry

Expected behavior

Example repo should serve as an example for usage in react-native environment.

Illustrations

N/A

Environment (please complete the following information):

  • Liveblocks @ 1.10.0
  • react-native @ 0.73.5

Additional context

N/A

@doelgonzo doelgonzo added bug Something isn't working triage needed The issue needs to be reviewed by the team labels Feb 29, 2024
@adigau adigau added the public repo label Apr 15, 2024 — with Linear
@adigau adigau removed triage needed The issue needs to be reviewed by the team public repo labels Apr 15, 2024
@adigau adigau added the experience label Apr 24, 2024 — with Linear
@adigau adigau removed the experience label Apr 24, 2024
@adigau adigau added the experience label May 9, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working experience
Projects
None yet
Development

No branches or pull requests

2 participants