Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated chain spec in parachain-launch #2363

Closed

Conversation

Traf333
Copy link
Contributor

@Traf333 Traf333 commented Dec 26, 2023

this PR tends to remove workaround (#2098) in order to keep things simple and consistent without supporting forked packages

Fixes: #2099

Copy link

linear bot commented Dec 26, 2023

@Traf333
Copy link
Contributor Author

Traf333 commented Dec 26, 2023

In addition, I've triggered whole system build to be sure the CI will work in case we touch some rust code
https://github.com/litentry/litentry-parachain/actions/runs/7330479550

@Kailai-Wang
Copy link
Collaborator

Could you explain a bit why this PR fixes the issue? I don't get it 😂

@Traf333
Copy link
Contributor Author

Traf333 commented Dec 27, 2023

Could you explain a bit why this PR fixes the issue? I don't get it 😂

As from description I understood that we got some tests failing in CI and we introduced workaround #2098

Maybe I understood the issue in a wrong way 🤔

if it's not the case, can you help me to understand what's the expected result? @Kailai-Wang

@Kailai-Wang
Copy link
Collaborator

As from description I understood that we got some tests failing in CI and we introduced workaround #2098

This is correct, but simply reverting this PR won't solve the problem :(

The issue is aimed to find the root cause and really "fix" it instead of working around it

@Traf333
Copy link
Contributor Author

Traf333 commented Dec 27, 2023

This PR includes not only reverting your PR, but

  • updated some packages
  • preventing build for the @open-web3/parachain-launch which might cause the issue

and I was thinking if the tests are green - it means the issue is solved 😄
since I reverted the workaround, probably now we should be able to see the issue, right? do you know how can I reproduce it?

@Kailai-Wang
Copy link
Collaborator

do you know how can I reproduce it?

This is the hardest part, the issue was a race condition that (I believe) was related to the I/O buffering. While it worked most of the time, it did fail sometimes.

You could read the links (to upstream PRs/issues, which are linked again to other issues) in the original PR thoroughly.

We can also revert it (but then maybe you want a higher version of the package) and see how it goes, but that's not a legit "fix" :)

@0xverin
Copy link
Contributor

0xverin commented Dec 27, 2023

do you know how can I reproduce it?

As we briefly discussed in the meeting, this part is challenging to reproduce, which is also why I mentioned "not sure." :p

@Traf333
Copy link
Contributor Author

Traf333 commented Dec 27, 2023

but then maybe you want a higher version of the package

Not sure there are any major changes which might be related to our case, even packages update are only touched dev packages
open-web3-stack/parachain-launch@v1.4.2...v2.0.0

Thanks for the input. 🙏 I'll re-read related issue and PR carefully and will continue to debug

@Kailai-Wang
Copy link
Collaborator

Thanks!

Feel free to jump on any other tasks that have a higher priority tho :)

@Traf333 Traf333 self-assigned this Dec 29, 2023
@Traf333 Traf333 added the D2-bug Something isn't working label Dec 29, 2023
@Traf333 Traf333 marked this pull request as draft December 29, 2023 10:30
@Traf333
Copy link
Contributor Author

Traf333 commented Jan 23, 2024

closing it for now as it stale and may pick up later

@Traf333 Traf333 closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D2-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix truncated chain spec in parachain-launch
3 participants