New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change draw_borders algorithm #110

Open

blockspacer opened this issue Oct 13, 2019 · 0 comments

blockspacer commented Oct 13, 2019

WebKit draws rounded borders differently from https://github.com/litehtml/litehtml/blob/master/containers/cairo/cairo_container.cpp#L347

See RenderBoxModelObject from WebKit

https://github.com/rkudiyarov/ClutterWebkit/blob/05d919e0598691bcd34f57d27f44872919e39e92/WebCore/rendering/RenderBoxModelObject.cpp#L1002

See as possible algorithm implementation with litehtml:

https://github.com/blockspacer/litehtml-qt-widget/blob/master/containers/qt5/container_qt5.cpp#L1238

Note that https://github.com/blockspacer/litehtml-qt-widget/blob/master/containers/qt5/ added extra features like:

gradients
background clip & radius blockspacer/litehtml-qt-widget@9d8aea1
dashed borders blockspacer/litehtml-qt-widget@cd08367
multiple shadows blockspacer/litehtml-qt-widget@4082218
qt line drawing. qt line drawing may be buggy because of qt floating point issues, prefer cairo

The text was updated successfully, but these errors were encountered:

blockspacer mentioned this issue

Please add text shadow support. #78

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment