Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when commands listed in EmptyView are unbound. #1776

Open
gmardom opened this issue Apr 21, 2024 · 0 comments
Open

Error when commands listed in EmptyView are unbound. #1776

gmardom opened this issue Apr 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gmardom
Copy link

gmardom commented Apr 21, 2024

When I disabled default bindings to assign my own from scratch, lite-xl stopped working.

Minimal Config

local keymap = require "core.keymap"

keymap.map = {}
keymap.reverse_map = {}

Lua stack trace

Error: /home/dominik/.local/share/lite-xl/data/core/emptyview.lua:37: bad argument #2 to 'format' (no value)
stack traceback:
	[C]: in function 'string.format'
	/home/dominik/.local/share/lite-xl/data/core/emptyview.lua:37: in upvalue 'draw_text'
	/home/dominik/.local/share/lite-xl/data/core/emptyview.lua:46: in function 'core.emptyview.draw'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:592: in function 'core.node.draw'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:32: in function 'core.node.propagate'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:597: in function 'core.node.draw'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:31: in function 'core.node.propagate'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:597: in function 'core.node.draw'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:32: in function 'core.node.propagate'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:597: in function 'core.node.draw'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:32: in function 'core.node.propagate'
	/home/dominik/.local/share/lite-xl/data/core/node.lua:597: in function 'core.node.draw'
	/home/dominik/.local/share/lite-xl/data/core/rootview.lua:454: in upvalue 'draw'
	...minik/.local/share/lite-xl/data/plugins/autocomplete.lua:598: in upvalue 'root_view_draw'
	...ominik/.local/share/lite-xl/data/plugins/contextmenu.lua:32: in upvalue 'root_view_draw'
	...e/dominik/.local/share/lite-xl/data/plugins/treeview.lua:498: in function 'core.rootview.draw'
	/home/dominik/.local/share/lite-xl/data/core/init.lua:1348: in function 'core.step'
	/home/dominik/.local/share/lite-xl/data/core/init.lua:1404: in function 'core.run'
	(...tail calls...)
	[string "local core..."]:14: in function <[string "local core..."]:6>
	[C]: in function 'xpcall'
	[string "local core..."]:6: in main chunk

Potential solution

   y = y + (dh - (th + style.padding.y) * #lines) / 2
   local w = 0
   for _, line in ipairs(lines) do
-    local text = string.format(line.fmt, keymap.get_binding(line.cmd))
+    local text = string.format(line.fmt, keymap.get_binding(line.cmd) or "N/A")
     w = math.max(w, renderer.draw_text(style.font, text, x + style.padding.x, y, color))
     y = y + th + style.padding.y
   end
@Guldoman Guldoman added the bug Something isn't working label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants