LP_PATH_METHOD truncate till VCS root

[sisoe24]

Truncate path till VCS root directory.

Description

When changing the directory to a VCS directory, truncate everything before the VSC root directory.

How will this be useful?

When working in a VCS environment, most of the path that leads to it can be superfluous since the focus is the environment.

Example prompt

[Rycieos]

Note that isn't a new suggestion: it was requested in #349 and then implemented in #465. However, since then, I have completely reworked how path generation is handled, and so #465 is very much impossible to merge.

I never got around to doing it myself as the original reporter and PR opener never reappeared. There didn't seem to be any interest in such a feature.

But now with this request, I will try to implement this myself. I admit that the new path shortening code is very complicated, so I wouldn't want to ask anyone else not familiar with it to attempt it.

[Rycieos]

Upon inspection and further thought; this needs some user stories.

If we add a new value for LP_PATH_METHOD, like truncate_to_vcs_dir, how would we know how to handle the rest of the shortening? For example, a directory like /Users/Rycieos/projects/liquidprompt/contrib/dist/archlinux-aur, where liquidprompt is the VCS root, and LP_PATH_LENGTH=35 and COLUMNS=100.

1. Ignore the LP_PATH_LENGTH setting, and just do the VCS root shortening: liquidprompt/contrib/dist/archlinux-aur. (Note this is longer than the config specifies.)
2. Make this VCS root truncating a different config option (like bool LP_PATH_VCS_ROOT_TRUNCATE), so that the different path shortening types could still be configured. Which would lead to displays like:
   a. LP_PATH_METHOD=truncate_chars_from_path_left: liquidprompt/.../dist/archlinux-aur
   b. LP_PATH_METHOD=truncate_chars_from_dir_right: liquidprompt/con.../dist/archlinux-aur
   b. LP_PATH_METHOD=truncate_chars_to_unique_dir: liquidprompt/c/dist/archlinux-aur
3. Do the same as option 2, but instead of a new config option, we make LP_PATH_METHOD able to accept multiple types at the same time. So LP_PATH_METHOD='truncate_to_vcs_dir,truncate_chars_to_unique_dir' would result in: liquidprompt/c/dist/archlinux-aur. Then (where possible) we would do each shortening type in order, only continuing as long as the path continued to be too long.

Thoughts?

[nojhan]

I like the third idea, which may also have the potential to simplify the code. It should probably be added that the last method to be mentioned may be applied several times, whether the previous ones would be applied only once.

[Rycieos]

It should probably be added that the last method to be mentioned may be applied several times, whether the previous ones would be applied only once.

I disagree, I think the first option should be applied as many times as possible, then the next one as many times as possible, etc. For options like what this issue is requesting, obviously you can only remove the part of the path before the VCS root once, so it doesn't matter.