[0.9.0] linthtml() function doesn't default export

[regseb]

Version 0.9.0 no longer exports the linthtml() function by default. I think the problem is with the TypeScript transpiler or the module bundler, because index.ts exports function by default.

---

import linthtml from "@linthtml/linthtml";

console.log(linthtml);

With 0.9.0:

{
  config_from_path: [Getter],
  find_local_config: [Getter],
  default: [Function: linthtml] {
    fromConfig: [Function: fromConfig],
    create_linters_for_files: [Function (anonymous)],
    from_config_path: [Function (anonymous)],
    Linter: [class Linter],
    LegacyLinter: [class Linter],
    rules: [Array],
    presets: {
      none: [Object],
      accessibility: [Object],
      validate: [Object],
      default: [Object]
    }
  }
}

With 0.8.6:

[Function: linthtml] {
  fromConfig: [Function (anonymous)],
  create_linters_for_files: [Function (anonymous)],
  from_config_path: [Function (anonymous)],
  Linter: [class Linter],
  LegacyLinter: [class Linter],
  rules: [Array],
  messages: [Object]
}

[KamiKillertO]

@regseb Thanks for reporting, I'll look into it.

[bootstrapdisruptive]

Seems like this breaks the LintHTML VSC extension. Celan install of both resluts in the error message "linthtml: lintHTML is not a function. Check your config file" when I open a html file in VSC.

[KamiKillertO]

I've started invetigating the problem.
I'm curious @regseb, why is that an issue for you? Are you directly using linthtml somewhere?

[regseb]

I am developing a project that aggregates several linters (using at API) : Metalint. I integrate LintHTML and I found this difference by upgrading to version 0.9.0. I can work around it, but I reported this problem because I don't think this change is voluntary.

[KamiKillertO]

I'm happy to hear of people using LintHTML to build other things.
Yeah, it's an unwanted change. The Typescript migration was a challenge, and it looks like I missed a few things.

[KamiKillertO]

@regseb So, I had a look, and because the codebase is now written in Typescript, it's not possible to bring back the previous export.

[KamiKillertO]

@HOKComics The latest version has a fix for the vscode extension

[regseb]

If the default export isn't possible, the linthtml method should be exported normally.

Version	Import
0.8.x	import linthtml from "@linthtml/linthtml";
0.9.x	import LintHTML from "@linthtml/linthtml"; const linthtml = LintHTML.default;
0.10.x	import { linthtml } from "@linthtml/linthtml";

[KamiKillertO]

@regseb I need to think about it. Changing the export once again has many impacts, I'll need to update the vscode extension once again to support 3 different kind of export 😓 . I'm not sure it's good idea

[regseb]

You can keep the default export to not break the API. And add the normal export of the linthtml method.

Versions	import linthtml from "...";	import LintHTML from "..."; const linthtml = LintHTML.default;	import { linthtml } from "...";
0.8.x	✔️	❌	❌
0.9.x	❌	✔️	❌
0.10.x	❌	✔️	✔️

---

linthtml/packages/linthtml/lib/index.ts

Line 151 in f75f84a

export { config_from_path, find_local_config, LegacyLinterConfig, LinterConfig };

- export { config_from_path, find_local_config, LegacyLinterConfig, LinterConfig };
+ export { linthtml, config_from_path, find_local_config, LegacyLinterConfig, LinterConfig };