Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "nomodule" to attr-req-value rule #454

Open
lawlesscreation opened this issue Jun 27, 2022 · 2 comments
Open

Add "nomodule" to attr-req-value rule #454

lawlesscreation opened this issue Jun 27, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@lawlesscreation
Copy link
Contributor

Hi, it seems the "nomodule" attribute is not in the list of allowed boolean attributes:

<script nomodule src="/file.js"></script>

results in:

error The attribute "nomodule" requires a value attr-req-value

But I believe it is a valid boolean attribute https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-nomodule.

@KamiKillertO
Copy link
Collaborator

Thanks for reporting 👍 .
The list of boolean attributes is definitively not up to date and needs to be updated.
Feel free to open a pull request (boolean attributes are listed here).

@KamiKillertO KamiKillertO added the bug Something isn't working label Jul 6, 2022
@nikolai-shabalin
Copy link
Contributor

nikolai-shabalin commented Jul 10, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants