Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --include-range-class-descendants option to "linkml-convert" #1629

Open
Silvanoc opened this issue Sep 15, 2023 · 0 comments · May be fixed by #1630
Open

Add --include-range-class-descendants option to "linkml-convert" #1629

Silvanoc opened this issue Sep 15, 2023 · 0 comments · May be fixed by #1630
Labels
community-generated developer-days smallish tickets that can be considered "maintenance" and fixed within a single session enhancement New feature or request linkml-convert

Comments

@Silvanoc
Copy link
Contributor

Is your feature request related to a problem? Please describe.

linkml-convert doesn't accept children of a class specified in a range as valid. Being used to the behavior of inheritance in OOP that also applies to the generated Python code, I find it misleading and frustrating.

Describe the solution you'd like
IMO (point of view of an OOP programmer, might be different for an "ontologist") accepting children should be the default behavior. Since gen-json-schema and linkml-validate already have the option --include-range-class-descendants, having such an option for linkml-convert would be also fine for me.

How important is this feature? Select from the options below:
• Medium - As of now I have to ignore validation errors that appear due to this limitation of linkml-convert

When will use cases depending on this become relevant? Select from the options below:
• Short-term - 2-4 weeks

Additional context
I'm providing a PR to implement this feature.

@Silvanoc Silvanoc linked a pull request Sep 15, 2023 that will close this issue
@sierra-moxon sierra-moxon added the developer-days smallish tickets that can be considered "maintenance" and fixed within a single session label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-generated developer-days smallish tickets that can be considered "maintenance" and fixed within a single session enhancement New feature or request linkml-convert
Development

Successfully merging a pull request may close this issue.

3 participants