New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull-destination-proto.sh should use a pinned version #2403

Open

olix0r opened this issue Jun 25, 2020 · 0 comments

Projects

Linkerd 1.x Backlog. See https://gith...

Member

olix0r commented Jun 25, 2020 •

edited

There's a namerd script that is pinned to the master branch of linkerd2-proxy-api (which no longer exists):

namerd/iface/destination/src/main/resources/pull-destination-proto.sh:DESTINATION_PROTO=$(curl https://raw.githubusercontent.com/linkerd/linkerd2-proxy-api/master/proto/destination.proto)
namerd/iface/destination/src/main/resources/pull-destination-proto.sh:NET_PROTO=$(curl https://raw.githubusercontent.com/linkerd/linkerd2-proxy-api/master/proto/net.proto)

This should be pinned to a specific tag or SHA.

The text was updated successfully, but these errors were encountered:

adleong added this to Bug in Linkerd 1.x Backlog. See https://github.com/linkerd/linkerd2/blob/main/ROADMAP.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment