-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guava compile dependencies on runtime classpath #1934
Comments
Hi @robobario , I think the intent is reasonable at least for your use cases. I'm concerned about what if in the future people make some changes that needs those dependencies? Or if people have their own CC branches that need some of those dependencies. |
I feel it's still safe to leave it there, unless it would affect performance or will add notable complexity during building or runtime. |
True, it's safest to leave it since there's caveats around reflective access, maybe it'd break something in future. Thanks |
Hi, we build/run cruise-control and noticed that some guava compile dependencies are on the runtime path. As a user we'd like the minimum set of dependencies on the classpath. We currently exclude them in our build and wondered if it was worth doing the same upstream.
They are:
https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies
Thank you
The text was updated successfully, but these errors were encountered: