Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lingui extract should fail with a non-zero exit code when there are extraction failures #1419

Open
thekip opened this issue Feb 9, 2023 · 5 comments
Labels

Comments

@thekip
Copy link
Collaborator

thekip commented Feb 9, 2023

There was already a work on that:
#1299

But still there are cases where errors just logged to console and zero code is returned.

For example, "Missing Message ID" warning.

What should be done:

We should add a flag to the cli extract, for example --strict which will exit with non-zero code in case of any extraction problems encountered.

Related:
Look what hacks users have to do to achieve this:
https://github.com/KlimaDAO/klimadao/blob/staging/scripts/lingui.js

@landsman
Copy link
Contributor

landsman commented Mar 3, 2023

I was thinking how to hot-fix this today as well.

@thekip
Copy link
Collaborator Author

thekip commented Mar 4, 2023

Hi, we are currently reworked an entire codebase for cli and extractor in V4. And this task already scheduled for new upcoming release. So "hofixing" to the main branch wouldn't have a lot of sense. If you want to help, you can implement this for the "next" branch

@andrii-bodnar
Copy link
Contributor

@thekip is this still relevant for the v4?

@thekip
Copy link
Collaborator Author

thekip commented Apr 21, 2023

Yes. Few of the checks are still "warning only", the big changes should be made to the codebase to stop processing after encountering these warnings.

@andrii-bodnar
Copy link
Contributor

It looks like it's not that critical and a big codebase change won't be worth it, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants