Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type check lightly.api #1387

Open
philippmwirth opened this issue Sep 13, 2023 · 0 comments
Open

Type check lightly.api #1387

philippmwirth opened this issue Sep 13, 2023 · 0 comments

Comments

@philippmwirth
Copy link
Contributor

philippmwirth commented Sep 13, 2023 •
edited

Type check lightly.api

  • Work through the excluded files with prefix lightly/api and tests/api in mypy.ini and type check one by one.
  • Remove follow_imports = skip for lightly.api.*.

Note: Typing the ApiWorkflowClient is a bit tricky because of the mixins. Mypy recommends typing mixins by making them implement a Protocol (see documentation).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Type checking
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philippmwirth