Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obsolete auto-tools scripts #28

Open
mcuee opened this issue Feb 26, 2023 · 6 comments
Open

Fix obsolete auto-tools scripts #28

mcuee opened this issue Feb 26, 2023 · 6 comments
Labels
build related to build scripts

Comments

@mcuee
Copy link
Member

mcuee commented Feb 26, 2023

There are quite some warnings now.

Example from github action Linux build.

Run ./autogen.sh --enable-examples-build && make -j4
  ./autogen.sh --enable-examples-build && make -j4
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
configure.ac:9: warning: The macro `AC_PROG_LIBTOOL' is obsolete.
configure.ac:9: You should run autoupdate.
m4/libtool.m4:99: AC_PROG_LIBTOOL is expanded from...
configure.ac:9: the top level
configure.ac:31: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:31: You should run autoupdate.
./lib/autoconf/general.m4:[2](https://github.com/libusb/libusb-compat-0.1/actions/runs/4275336152/jobs/7442610450#step:4:2)920: AC_TRY_LINK is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/libs.m4:100: AC_CHECK_LIB is expanded from...
m4/au_check_lib_soname.m4:11: AU_CHECK_LIB_SONAME is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/libs.m4:100: AC_CHECK_LIB is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/libs.m4:100: AC_CHECK_LIB is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/headers.m4:89: _AC_CHECK_HEADER_COMPILE is expanded from...
./lib/autoconf/headers.m4:56: AC_CHECK_HEADER is expanded from...
configure.ac:[3](https://github.com/libusb/libusb-compat-0.1/actions/runs/4275336152/jobs/7442610450#step:4:3)1: the top level
configure.ac:[4](https://github.com/libusb/libusb-compat-0.1/actions/runs/4275336152/jobs/7442610450#step:4:5)1: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:41: You should run autoupdate.
./lib/autoconf/general.m4:2847: AC_TRY_COMPILE is expanded from...
lib/m4sugar/m4sh.m4:[6](https://github.com/libusb/libusb-compat-0.1/actions/runs/4275336152/jobs/7442610450#step:4:7)92: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:699: AS_IF is expanded from...
./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from...
./lib/autoconf/general.m4:22[7](https://github.com/libusb/libusb-compat-0.1/actions/runs/4275336152/jobs/7442610450#step:4:8)0: AC_CACHE_CHECK is expanded from...
m4/au_have_gnu_errno.m4:6: AU_HAVE_GNU_ERRNO_H is expanded from...
@mcuee mcuee added the build related to build scripts label Feb 26, 2023
@mcuee mcuee changed the title Fix obsolte auto-tools scripts Fix obsolete auto-tools scripts Feb 26, 2023
@dmilith
Copy link

dmilith commented Jun 21, 2023

Yeah, autotools is a complete mess. I don't understand why maintainer doesn't provide tarball with autotools configure script generated. It's a mess.

@mcuee
Copy link
Member Author

mcuee commented Jun 21, 2023 •
edited

I don't understand why maintainer doesn't provide tarball with autotools configure script generated. It's a mess.

Good point. Let me try to do that over the weekend.

@zgyarmati
Copy link

Indeed, as the 0.1.7 version was released with generated configure and accompanying files (probably generated via make dist).
It would be nice to have this consequently between releases so we don't have to touch the build config when updating packages for downstream distros.

@mcuee
Copy link
Member Author

mcuee commented Oct 12, 2023 •
edited

Sorry for the late reply. I have replaced the github libusb-compat-0.1 release with the tarballs with autotools configure script generated.

Please report if there is an issue. Thanks.

@mcuee
Copy link
Member Author

mcuee commented Oct 12, 2023

Sourceforge release has also been updated.
https://sourceforge.net/projects/libusb/files/libusb-compat-0.1/libusb-compat-0.1.8/

@mcuee
Copy link
Member Author

mcuee commented Oct 12, 2023

PRs to fix the old scripts are welcome.

@heitbaum heitbaum mentioned this issue Oct 14, 2023
Merged
@cho-m cho-m mentioned this issue Oct 18, 2023
Merged
algitbot pushed a commit to alpinelinux/aports that referenced this issue Oct 20, 2023
@ncopa
main/libusb-compat: fix source URL
3d1e328 
upstream rebuild the release tarball without changing version.

libusb/libusb-compat-0.1#28 (comment)

switch to .tar.gz so we avoid distfiles cache problems
bell-sw pushed a commit to bell-sw/alpaquita-aports that referenced this issue Oct 26, 2023
@ncopa
universe/libusb-compat: fix source URL
771c226 
[ commit 3d1e3285bea8390e53ab085b806936d89e5aeed2 ]

upstream rebuild the release tarball without changing version.

libusb/libusb-compat-0.1#28 (comment)

switch to .tar.gz so we avoid distfiles cache problems
arnout pushed a commit to buildroot/buildroot that referenced this issue Nov 30, 2023
@sebszymanski @jacmet
package/libusb-compat: fix hash
d590c2c 
Upstream re-released the v0.1.8 tarballs with autotools related stuff. [1]
That makes the hash test to fail:

ERROR: while checking hashes from package/libusb-compat//libusb-compat.hash
ERROR: libusb-compat-0.1.8.tar.bz2 has wrong sha256 hash:
ERROR: expected: 698c76484f3dec1e0175067cbd1556c3021e94e7f2313ae3ea6a66d900e00827
ERROR: got     : b692dcf674c070c8c0bee3c8230ce4ee5903f926d77dc8b968a4dd1b70f9b05c
ERROR: Incomplete download, or man-in-the-middle (MITM) attack

Update the hash and drop LIBUSB_COMPAT_AUTORECONF.

[1] libusb/libusb-compat-0.1#28 (comment)

[Peter: use .tar.gz to not conflict with s.b.o]
Signed-off-by: Sébastien Szymanski <[email protected]>
Signed-off-by: Peter Korsgaard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build related to build scripts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmilith @mcuee @zgyarmati