Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .ico image format #869

Open
Orgoth opened this issue Oct 5, 2023 · 1 comment
Open

Support for .ico image format #869

Orgoth opened this issue Oct 5, 2023 · 1 comment

Comments

@Orgoth
Copy link

Orgoth commented Oct 5, 2023

I actually only have one question.
What exactly is the reason that GD-Lib does not support the .ico format. "https://de.wikipedia.org/wiki/ICO_(Dateiformat)"
The format is supported by all current browsers and also ImageMagick, only GD seems to be missing it.

The background is as follows.
I had a discussion with another developer who insisted that the format is no longer supported at all "HTML Spec, all Browsers, ImageMagick and GD-Lib" and a review of the whole thing showed that except for his statement about GD, all the others were wrong.

@vapier
Copy link
Member

vapier commented Oct 6, 2023

considering browsers allow favico.ico to be just about any format, and html has <link rel="icon" ...> tags for just about any format, the actual ico format isn't really that important.

that said, i'm not against adding support for the format since it isn't terribly complicated. patches w/unittest coverage welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants