Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.saveAlphaFlag ignored when saving WebP or AVIF #854

Open
cmb69 opened this issue Dec 6, 2022 · 1 comment
Open

.saveAlphaFlag ignored when saving WebP or AVIF #854

cmb69 opened this issue Dec 6, 2022 · 1 comment

Comments

@cmb69
Copy link
Contributor

cmb69 commented Dec 6, 2022

Neither gdImageWebpCtx() nor gdImageAvifCtx() care about .saveAlphaFlag, but always save the full alpha channel, while gdImagePngCtxEx() heeds that flag.

For details see php/php-src#10055. I can port that PR to libgd, but want to be sure that we actually classify this as bug, and if so which branch the fix should target. Given the lack of documentation about the alpha flag, and that WebP and AVIF behave this way since support has been introduced, we probably don't want to fix this in a revision. As such I suggest to fix it in the next minor (if there'll be a 2.4), or major (3.0).

@vapier
Copy link
Member

vapier commented Dec 7, 2022

sounds like a bug fix to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants