Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overwrite-globals build triggers a memory leak in Firefox #166

Open
tommoor opened this issue Mar 19, 2024 · 3 comments
Open

overwrite-globals build triggers a memory leak in Firefox #166

tommoor opened this issue Mar 19, 2024 · 3 comments

Comments

@tommoor
Copy link

tommoor commented Mar 19, 2024

I thought users of this library should be aware that it causes a memory leak in Firefox as they do not properly garbage collect the clipboard object, although a patch is in the works.

See more details on Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1886056

@lgarron
Copy link
Owner

lgarron commented Mar 19, 2024

Interesting, thanks for sharing!

Do you know why the overwrite-globals version of the library was used? It's generally much better to use the ponyfill when possible.

@lgarron lgarron changed the title overwrite-globals option triggers a memory leak in Firefox overwrite-globals build triggers a memory leak in Firefox Mar 19, 2024
@tommoor
Copy link
Author

tommoor commented Mar 19, 2024

I do not, presumably for ease though as it's a large codebase and hard to ensure that other engineers are aware of Firefox limitations

@tommoor
Copy link
Author

tommoor commented Mar 20, 2024

This issue is now addressed in Firefox Nightly build, feel free to close it out – I just wanted to make sure that anyone searching would know about the limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants