Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is a clerical error or correct? #92

Open
kall3001 opened this issue Sep 2, 2022 · 1 comment
Open

This is a clerical error or correct? #92

kall3001 opened this issue Sep 2, 2022 · 1 comment
Assignees
@lexus2k
Labels
bug Something isn't working

Comments

@kall3001
Copy link

kall3001 commented Sep 2, 2022 •
edited

File src/lcd_hal/esp/esp32_spi.cpp line 62:
if ( m_cs >= 0 )
{
lcd_gpioMode(m_cs, LCD_GPIO_OUTPUT);
lcd_gpioWrite(m_clk, LCD_HIGH);
}
About 'm_clk' ,this is a clerical error or correct?
@kall3001 kall3001 added the question Further information is requested label Sep 2, 2022
@lexus2k lexus2k added bug Something isn't working and removed question Further information is requested labels Sep 2, 2022
@lexus2k
Copy link
Owner

lexus2k commented Sep 2, 2022

Yes, this is misprint. Thank you for the finding

@kall3001 kall3001 closed this as completed Sep 4, 2022
@kall3001 kall3001 reopened this Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexus2k lexus2k

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexus2k @kall3001