Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Raspberry Pi Pico - Pull Request #116

Open
simon-77 opened this issue Apr 29, 2024 · 2 comments
Open

Add support for Raspberry Pi Pico - Pull Request #116

simon-77 opened this issue Apr 29, 2024 · 2 comments

Comments

@simon-77
Copy link
Contributor

The library lcdgfx has a long list of supported platforms, but it still lacks support for the Raspberry Pi Pico micro controller using the pico C/C++ SDK.

I have implemented some of the lcd_hal functions using the pico-sdk, especially for the SPI implementation and also verified this implementation using hardware.

Implementation

  • The hardware implementation is placed in the directory lcdgfx/src/lcd_hal/pico/
  • To enable this implementation, the define PICO_BOARD is used, which is defined when compiling for the Raspberry Pi Pico and can be used to distinguish between the two boards pico and pico_w (no difference between these boards is made here)
  • The i2c hal is not implemented, as I do not have hardware to verify this. Instead I added empty dummy functions (to be able to compile this project) and added a compiler warning #warning "I2C is not implemented for Pico board - this is a dummy"
  • The lcdgfx library uses the LCD_PROGMEM macro for data stored in flash. (e.g. const PROGMEM uint8_t heartImage[8]). The pico-sdk uses the __in_flash() macro after type definition like: const uint8_t __in_flash() heartImage[8].
    It is therefore unfortunately not possible to use the LCD_PROGMEM macro only using precompiler directives. I have defined the LCD_PROGMEM "blank" to be able to compile this library.

Using this library

As the Raspberry Pi Pico suite also uses CMake (and ninja) for the projects, it is fairly straight forward to "include" the source of this library (at least once I figured it out correctly).

I have provided an example with 4 additional statements in the CMakeList.txt of the Raspberry Pi Pico project to include the lcdgfx CMake folder, as well as to compile and link it correctly. Using the lcdgfx library does work the same as on the Arduino platform.

With this approach none additional compile or link process is required, as it is seemingly implemented into the CMake build process of the Raspberry Pi Pico prject.

Best regards
Simon

@simon-77
Copy link
Contributor Author

One workaround I forgot to mention regarding the SPI hardware:

The Rapsberry Pi Pico has 2 SPI hardware peripherals (spi0 and spi1) which can each be routed to multiple different pins.
The pin routing is implemented in the pico-hal and can be achieved by providing the correct pin numbers to the constructor of lcdgfx. As there are no additional parameters in the constructor, I used a define to distinguish between these 2 SPI peripherals

I have therefore introduced the following snippet of the pico_spi.h file:

#if defined(PICO_USE_SPI1)
#define PICO_SPI spi1
#else
#define PICO_SPI spi0
#endif

Maybe not the most elegant solution ... but I did not know how to do it otherwise.

@lexus2k
Copy link
Owner

lexus2k commented May 5, 2024

Hi @simon-77
You solution is merged to the project.
It passed automatic checked and conform code style.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants