-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistencies in W, H order #1
Comments
Thank you very much, I will fix this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello, while using the code in this repository I noticed an issue with the width and height parameters that impacts rectangular-shaped models:
1 - In client.py the shape is being passed as NCWH, rather than NCHW, which doesn't seem correct.
2- In preprocess the code clearly expects input_shape to be [height, width], while is being passed as [width, height] from client.py
3- In postprocess input_shape is used in a way that it's consistent to [width, height], based on the coordinates passed to BoungingBox ctor and the scaling. This is consistent with how they are being passed, but inconsistent with the preprocess method.
The text was updated successfully, but these errors were encountered: