Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup project for unit testing of the Wendy library #50

Open
5 tasks
levibostian opened this issue Dec 8, 2018 · 2 comments
Open
5 tasks

Setup project for unit testing of the Wendy library #50

levibostian opened this issue Dec 8, 2018 · 2 comments
Milestone

Comments

@levibostian
Copy link
Owner

levibostian commented Dec 8, 2018

Wendy needs testing around it. At this time, that is all done through an example Android app in this repo that you can use to try out Wendy and see how it works. However, we all know unit tests are better.

The repo is currently not setup for good unit testing. It needs to be setup so that tests can then be created and added.

  • Setup testing to work with dependency injection to allow using mocked objects.
  • CI server run tests on each push (or pull request).
  • Code coverage reporting would be nice to have, but at this time not required.

After this is done...

  • Create issue to write the unit tests.
  • Create issue to setup and write tests for the example app in this project. Why? Because developers will be writing tests with Wendy as a dependency. Wendy needs to have a good API for devs to test against it in their own apps.
@Grohden
Copy link
Contributor

Grohden commented Dec 9, 2018

For DI i would use Koin (just a suggestion) cuz it's really easy to make work and setup tests with

I also would use a linter in the project to enforce code quality (https://ktlint.github.io)

@levibostian
Copy link
Owner Author

Thanks for the suggestion, @Grohden. This issue is designed for adding unit testing specifically to the library. We should be able to pass in mocked objects into the constructors of each class in the Wendy library to test them without needing to use a library such as Koin or Dagger or others. The Wendy library itself should not need to have any 3rd party DI library installed to work.

However, for testing the example app, 3rd party libraries are acceptable. I only have experience with using Dagger2 but I have heard great things about Koin and am open to using that for tests in the example app.

@levibostian levibostian added this to the 0.3.0-alpha milestone Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants