Fix SetNamespace docs and behavior when namespace already exist #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitarpawat
suggested changes
Jun 26, 2024
Comment on lines
+50
to
62
| if oldNs, _ := clib.XMLSearchNs(doc, n, prefix); oldNs == 0 { | ||
| // Namespace not found, create a new one | ||
| ns, err := clib.XMLNewNs(n, uri, prefix) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if activateflag { | ||
| if err := clib.XMLSetNs(n, wrapNamespaceNode(ns)); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Using the same namespace pointer if it already exists
Suggested change
| if oldNs, _ := clib.XMLSearchNs(doc, n, prefix); oldNs == 0 { | |
| // Namespace not found, create a new one | |
| ns, err := clib.XMLNewNs(n, uri, prefix) | |
| if err != nil { | |
| return err | |
| } | |
| if activateflag { | |
| if err := clib.XMLSetNs(n, wrapNamespaceNode(ns)); err != nil { | |
| return err | |
| } | |
| } | |
| } | |
| ns, _ := clib.XMLSearchNs(doc, n, prefix) | |
| if ns == 0 { | |
| // Namespace not found, create a new one | |
| ns, err = clib.XMLNewNs(n, uri, prefix) | |
| if err != nil { | |
| return err | |
| } | |
| } | |
| if activateflag { | |
| if err := clib.XMLSetNs(n, wrapNamespaceNode(ns)); err != nil { | |
| return err | |
| } | |
| } |
| count := strings.Count(dump, `xmlns:ex="https://example.com"`) | ||
| t.Logf("%s", dump) | ||
| require.Equal(t, 1, count, "expected only one namespace declaration for 'ex' prefix") | ||
| }) |
There was a problem hiding this comment.
Add test to check namespace prefix
Suggested change
| }) | |
| // root.Dump(true) should contains namespace prefix for Document | |
| count = strings.Count(dump, "ex:Document") | |
| require.Equal(t, 2, count, "expected Document to have 'ex' namespace prefix") | |
| // root.Dump(true) should contains namespace prefix for Test | |
| count = strings.Count(dump, "ex:Test") | |
| require.Equal(t, 2, count, "expected Test to have 'ex' namespace prefix") | |
| }) |
| count := strings.Count(dump, `xmlns:ex="https://example.com"`) | ||
| t.Logf("%s", dump) | ||
| require.Equal(t, 2, count, "expected two namespace declaration for 'ex' prefix") | ||
| }) |
There was a problem hiding this comment.
Add test to check namespace prefix
Suggested change
| }) | |
| // root.Dump(true) should contains namespace prefix for Document | |
| count = strings.Count(dump, "ex:Document") | |
| require.Equal(t, 2, count, "expected Document to have 'ex' namespace prefix") | |
| // root.Dump(true) should contains namespace prefix for Test | |
| count = strings.Count(dump, "ex:Test") | |
| require.Equal(t, 2, count, "expected Test to have 'ex' namespace prefix") | |
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #102