-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuring Published Files: blocks copying of assets into source location #3958
Labels
Comments
lerna/libs/commands/publish/src/index.ts Lines 1124 to 1126 in 13c80ae
Actually, I wonder too if the preceding conditionally never gets the configuration from the following code: lerna/libs/commands/publish/src/index.ts Lines 297 to 306 in 13c80ae
I do see this log for the my configuration, but this conditional still catches and returns early. lerna verb silly Interpolated string "../../README.md" for node "package-a" to produce "../../README.md" {
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"npmClient": "pnpm",
"version": "independent",
"changelogPreset": "conventional-changelog-conventionalcommits",
"command": {
"version": {
"message": "chore(release): publish",
"conventionalCommits": true,
"private": false
},
"publish": {
"registry": "https://npm.pkg.github.com/",
"private": false,
"assets": [
"../../README.md"
]
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Documentation issue
Is there a specific documentation page you are reporting?
https://lerna.js.org/docs/concepts/configuring-published-files#--directory
Additional context or description
I've struggled for a considerable amount of time before looking at the source to find that copying of assets is being blocked when the trying to copy into the source location.
lerna/libs/commands/publish/src/index.ts
Lines 1128 to 1131 in 13c80ae
This isn't clear in the documentation. But why even block copying under this condition?
For example, I have a mono-repo with
package-a
andpackage-b
that source assets from{workspaceRoot}
. This scenario doesn't currently work.I'm willing to create a PR, if you agree this restriction should be removed. Let me know.
The text was updated successfully, but these errors were encountered: