Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Convert px to rem #1181

Open
coudrak opened this issue Jan 15, 2022 · 3 comments
Open

[Request] Convert px to rem #1181

coudrak opened this issue Jan 15, 2022 · 3 comments
Labels
Feature Feature requests/suggestions

Comments

@coudrak
Copy link

coudrak commented Jan 15, 2022

I think it would be good to update the less files to replace all the css px with rem values.
Most of modern projects switched to rem, like Boostrap.

@leongersen
Copy link
Owner

Thanks for your suggestion. What advantage would you see in making this migration?

Related to #1167.

@leongersen leongersen added the Feature Feature requests/suggestions label Jan 19, 2022
@coudrak
Copy link
Author

coudrak commented Jan 19, 2022

For example, in my case, I "zoom out" my page by 75% on mobile screens less than 360px wide, in this way:

:root {
   font-size: 75%;
}

I use Bootstrap, so everything in my page decreases, except the slider because it is in px.

@leongersen
Copy link
Owner

Right, that makes sense. Given that is would be a tricky breaking change, in particular for restyled sliders, it would be good to pick this up together with the issue linked above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature requests/suggestions
Projects
None yet
Development

No branches or pull requests

2 participants