Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Deploy #165

Open
8 of 11 tasks
leocaseiro opened this issue Feb 29, 2016 · 10 comments
Open
8 of 11 tasks

Automatically Deploy #165

leocaseiro opened this issue Feb 29, 2016 · 10 comments

Comments

@leocaseiro
Copy link
Owner

leocaseiro commented Feb 29, 2016

  • Create Gulp file
  • Add .coffeelint
  • Add .editorconfig
  • Add .min.js compiled
  • Rename from chosen.js to angular-chosen.js (perhaps)
  • Add Unit Tests (specially for fix issues)
  • Configure Travis with Github for new PR
  • Generate documentation with Slate at docs branch
  • Use Conventional Changelog
  • Commit using commitizen
  • Write a CONTRIBUTING.md following angular-formly as reference
@leocaseiro
Copy link
Owner Author

Gulp Tasks

Main Tasks

  • build: Compile CoffeeScript and minify Javascript generated
  • watcher: Watch in real-time while Compile CoffeeScripts and minify Javascript generated

Sub Tasks

  • build-clean-javascripts: Clean ./dist/
  • build-coffee-script: Compile ./src/chosen.coffee into ./dist/angular-chosen.js
  • build-minify: Minify ./dist/angular-chosen.js into ./dist/angular-chosen.min.js

@leocaseiro
Copy link
Owner Author

Documentation is at docs branch and probably will remain there.

We are using Slate
Edit using markdown /docs/source/index.html.md or /docs/source/includes/_examples.html.md

To deploy docs, run:

./deploy.sh 

@simison
Copy link
Contributor

simison commented Mar 11, 2016

Recommend to also add http://editorconfig.org/ file alongside with jshint.

Tho suppose you need coffeelint instead?

@simison
Copy link
Contributor

simison commented Mar 11, 2016

BTW Bower recommends not to add minified files:
https://github.com/bower/spec/blob/master/json.md

Do not include minified files.

@xts-velkumars
Copy link

Hi,
I'm using angular chosen in my project, problem is after gulp build chosen icons are missing, please advise me

image

@simison
Copy link
Contributor

simison commented Jun 21, 2017 via email

@xts-velkumars
Copy link

@simison, i did that i can clearly see "chosen-sprite.png" not bundled it seems after my minification process

@simison
Copy link
Contributor

simison commented Jun 21, 2017 via email

@simison
Copy link
Contributor

simison commented Jun 21, 2017

@velkumars: I just realised this is under an issue on another topic (I didn't realise it via emails). It's not polite to go off topic, but to open new issues instead. Better even use Stackoverflow since this isn't really a bug in library or anything like that.

@leocaseiro
Copy link
Owner Author

Hi @velkumars, this is not related to the Automatically Deploy, please, open your own issue.
Also, I believe you haven't loaded properly your CSS from chosen library.

Thanks @simison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants