Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded Secrets #13

Open
sabrehagen opened this issue Aug 14, 2019 · 3 comments
Open

Hardcoded Secrets #13

sabrehagen opened this issue Aug 14, 2019 · 3 comments

Comments

@sabrehagen
Copy link

It seems the OAuth app details are hardcoded into the source. Example 1 Example 2.

Can this be changed to use a central config source (like in cloudbrowser), and can that config inherit from environment variables, not hardcoded source values that require a recompile?

@lemourin
Copy link
Owner

Hardcoded secrets are only for testing purposes. The management of secrets is a responsibility of a libcloudstorage client. cloudstorage-fuse (being a libcloudstorage client) currently doesn't load secrets from elsewhere.

@sabrehagen
Copy link
Author

sabrehagen commented Aug 18, 2019

The management of secrets is a responsibility of a libcloudstorage client. cloudstorage-fuse (being a libcloudstorage client) currently doesn't load secrets from elsewhere.

I'm trying to figure this out but can't. Rephrasing your words might highlight my confusion:

The libcloudstorage cloudstorage-fuse client is responsible for managing secrets, and currently doesn't load secrets from elsewhere.

If this is the case, where does cloudstorage-fuse load its secrets from that it is responsible for? I can't locate any secrets under /bin/fuse.

@lemourin
Copy link
Owner

cloudstorage-fuse doesn't load secrets from anywhere which means that it just uses the default hardcoded secrets. Loading from other place is not currently implemented in cloudstorage-fuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants