System freezes when closing Thorium #1168

copypasteonly · 2023-11-04T15:56:28Z

Describe the bug

When closing thorium using the CloseWindow command, the whole system freezes. No keybindings (even switching to another tty) would work but the cursor will still move.

Expected behavior (optional)

System shouldn't freeze

Steps to reproduce (optional)

Close Thorium
System Freeze

Relevant log output (optional)

Not sure if this log is relevant, also not sure if this was the time when I closed my window.

Nov 04 23:35:19 framework leftwm-worker[1253]: AVOID STRUT:[XlibHandle(25165825)] Xyhw { x: 0, y: 212, h: 40, w: 1919, minw: -999999999, maxw: 999999999, minh: -999999999, maxh: 999999999 }
Nov 04 23:35:19 framework leftwm-worker[1253]: AVOID STRUT:[XlibHandle(23068673)] Xyhw { x: 1920, y: 0, h: 40, w: 2255, minw: -999999999, maxw: 999999999, minh: -999999999, maxh: 999999999 }
Nov 04 23:38:20 framework assert_20231104233820_84.dmp[18264]: Uploading dump (out-of-process)
                                                               /tmp/dumps/assert_20231104233820_84.dmp

OS / Distro

Linux framework 6.5.9-arch2-1 #1 SMP PREEMPT_DYNAMIC Thu, 26 Oct 2023 00:52:20 +0000 x86_64 GNU/Linux

Additional System Information (optional)

On a Framework i5 - 1135g7 Laptop with an external monitor hooked up.

LeftWM Check

:: LeftWM version: 0.4.2
:: LeftWM git hash: 357aea5
:: Enabled features:  journald-log lefthk
:: Checking feature dependencies . . .
    -> journald-log OK
    -> lefthk OK
:: Checking for leftwm binaries . . .
    -> Binaries OK 
:: Loading configuration . . .
    -> Configuration loaded OK 
:: Checking keybinds . . .
    -> All keybinds OK
:: Checking environment . . .
    -> Environment OK 
:: Checking theme . . .
    -> Theme OK

The text was updated successfully, but these errors were encountered:

Eskaan · 2023-11-04T19:12:06Z

I want to note that I am experiencing a similar behavior when opening rofi using a keybind and then running mpc n. This should autocomplete to mpc next and return almost instantly, instead all keybinds cease to work indefinitely. This might be related but doesn't has to be.

VuiMuich · 2023-11-06T15:40:49Z

@Eskaan how exactly are you using rofi? For me rofi -show drun is working just fine for me.
Seems like thorium is taking a bit to get packaged for nixos, so I can'r effortless test this either.

@copypasteonly could you please try to launch thorium from a terminal and see if it logs anything there?

PS: my rofi info:

Monitor layout:
              ID: 0 (primary)
            name: eDP-1
        position: 0,0
            size: 2560,1440
            size: 310mm,174mm  dpi: 210,210


Detected modes:
        • +window
        • windowcd
        • +run
        • +ssh
        • +drun
        • combi
        • keys
        • filebrowser

Detected user scripts:

Compile time options:
	• Pango   version 1.50.14
	• window  enabled
	• drun    enabled
	• gcov    disabled
	• asan    disabled

For more information see: man rofi
                 Version: 1.7.5
              Bugreports: https://github.com/davatorium/rofi/
                 Support: https://reddit.com/r/qtools/
                          #rofi @ libera.chat
      Configuration file: /home/vuimuich/.config/rofi/config.rasi

Eskaan · 2023-11-06T19:06:29Z

@VuiMuich rofi itself is working fine for me, it's only when I execute this specific command (mpc n) with rofi that my entire X11 freezes. Haven't really debugged that yet as using the full command (mpc next) works. I just wanted to say it might be related.

VuiMuich · 2023-11-07T07:27:16Z

Ok, I'll try to see if I can find something about this tonight.

BTW: was able to build the Thorium from the packaging PR for NixOS (Thorium About: Version 117.0.5938.157 (Official Build) stable, built on Linux (64-bit)) and can't reproduce OP's issue either. Is it possibly some Arch dependency causing this issue?

Also BTW my Kernel info: Linux nixbook 6.5.9 #1-NixOS SMP PREEMPT_DYNAMIC Wed Oct 25 10:16:30 UTC 2023 x86_64 GNU/Linux

VuiMuich · 2023-11-10T21:59:47Z

🤔 I have been trying my best, but I could not reproduce neither of the freeze situations, I am sorry. As I don't want to hold back the 0.5.0 release for too long I say if there is a meaningful attempt or some further info to reproduce this issue reliably, we can wait for a fix a couple of days longer, but if it seems stalled by the end of the weekend I'd say we publish 0.5.0 without this fixed.

copypasteonly · 2023-11-11T16:07:04Z

🤔 I have been trying my best, but I could not reproduce neither of the freeze situations, I am sorry. As I don't want to hold back the 0.5.0 release for too long I say if there is a meaningful attempt or some further info to reproduce this issue reliably, we can wait for a fix a couple of days longer, but if it seems stalled by the end of the weekend I'd say we publish 0.5.0 without this fixed.

Hello sorry for the late feedback but I'm trying to also reproduce it 100% of the time since it happens randomly. I've also noticed that the freezes is not limited to thorium, I've experienced it with other applications as well such as Steam. It also has seemed to get better as time goes by, since after some time it will return normally unlike before which it never did. It might just be a weird Arch dependency issue or a kernel issue since I started having this problem on October.

VuiMuich · 2023-11-12T08:22:18Z

Quite a while ago there was some severe freezes, when discord tried to send notifications but there was no daemon present.

So, as the exact cause to these recent freeze issues remains uncertain, I'd say we release 0.5.0 right away and a fix for this has to wait for an upcoming release.

VuiMuich · 2023-11-23T10:01:05Z

I might have found something:

While I was trying to push the leftwm repo to our codeberg mirror a pop-up by x11-ssh-askpass pops up to authenticate to the remote (which failed btw.). This causes a freeze of leftwm-worker. As I still had the terminal open I Ctrl-C cancelled the git push and tried leftwm-command "SoftReload" and got a timeout from the return pipe. So I guess the killed window sends leftwm-worker into some loop trying to do some action that never gets cleared from the command pipe.

Edit: I reproduced the freeze, but this time I captured a few bits of info from the remaining terminal session:

leftwm on  main via 🦀 v1.72.0 via ❄  impure (shell)
>>> leftwm check
:: LeftWM version: 0.5.0
:: LeftWM git hash: 79403d5
:: Enabled features:  journald-log lefthk
:: Checking feature dependencies . . .
    -> journald-log OK
    -> lefthk OK
:: Checking for leftwm binaries . . .
    -> Binaries OK
:: Loading configuration . . .
    -> Configuration loaded OK
:: Checking keybinds . . .
    -> All keybinds OK
:: Checking environment . . .
    -> Environment OK
:: Checking theme . . .
    -> Theme OK
leftwm on  main via 🦀 v1.72.0 via ❄  impure (shell)
>>> leftwm state -q
{"window_title":"OpenSSH Authentication Passphrase Request","workspaces":[{"id":1,"output":"eDP-1","h":1440,"w":2560,"x":0,"y":0,"layout":"MainAndDeck","index":0,"tags":[{"name":"󰋜","index":0,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":true},{"name":"","index":1,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":true},{"name":"󰊢","index":2,"mine":true,"visible":true,"focused":true,"urgent":false,"busy":true},{"name":"","index":3,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":false},{"name":"󰆍","index":4,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":false},{"name":"󱓞","index":5,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":false},{"name":"","index":6,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":false},{"name":"󰙯","index":7,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":true},{"name":"","index":8,"mine":false,"visible":false,"focused":false,"urgent":false,"busy":false}]}]}
leftwm on  main via 🦀 v1.72.0 via ❄  impure (shell)
leftwm on  main via 🦀 v1.72.0 via ❄  impure (shell)
>>> leftwm-command "SoftReload"
SoftReload: command executed successfully
leftwm on  main via 🦀 v1.72.0 via ❄  impure (shell)
>>> leftwm-command "HardReload"
 WARN: timeout connecting to return pipe. Command may have executed, but errors will not be displayed.
[ble: exit 1]
leftwm on  main via 🦀 v1.72.0 via ❄  impure (shell) took 5s
>>>

Eskaan · 2023-12-18T17:15:15Z

@VuiMuich I fixed the problem I had (see #1196), is it fixed for you too with that (I don't think so)?

Edit: You might try to reproduce the issue with my heavy logging branch and see where the event loop gets stuck.
(diff is commit a4fd288)

copypasteonly added the bug Something isn't working label Nov 4, 2023

mautamu mentioned this issue Nov 6, 2023

chore: Release leftwm 0.5.0, XDS 0.1.2 #1170

Merged

7 tasks

Eskaan mentioned this issue Dec 13, 2023

Lefthk freezes when keybind program tries to aquire terminal buffer #1196

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

System freezes when closing Thorium #1168

System freezes when closing Thorium #1168

copypasteonly commented Nov 4, 2023

Eskaan commented Nov 4, 2023 •

edited

VuiMuich commented Nov 6, 2023

Eskaan commented Nov 6, 2023

VuiMuich commented Nov 7, 2023 •

edited

VuiMuich commented Nov 10, 2023

copypasteonly commented Nov 11, 2023

VuiMuich commented Nov 12, 2023

VuiMuich commented Nov 23, 2023 •

edited

Eskaan commented Dec 18, 2023 •

edited

System freezes when closing Thorium #1168

System freezes when closing Thorium #1168

Comments

copypasteonly commented Nov 4, 2023

Describe the bug

Expected behavior (optional)

Steps to reproduce (optional)

Relevant log output (optional)

OS / Distro

Additional System Information (optional)

LeftWM Check

Eskaan commented Nov 4, 2023 • edited

VuiMuich commented Nov 6, 2023

Eskaan commented Nov 6, 2023

VuiMuich commented Nov 7, 2023 • edited

VuiMuich commented Nov 10, 2023

copypasteonly commented Nov 11, 2023

VuiMuich commented Nov 12, 2023

VuiMuich commented Nov 23, 2023 • edited

Eskaan commented Dec 18, 2023 • edited

Eskaan commented Nov 4, 2023 •

edited

VuiMuich commented Nov 7, 2023 •

edited

VuiMuich commented Nov 23, 2023 •

edited

Eskaan commented Dec 18, 2023 •

edited