[ledger-report] Delay report command expansion #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea |
Delays the expansion of the report command until execution time. This leaves the command in `ledger-report-cmd' unexpanded, which prevents the expanded version of the command from being edited / saved by the user. Resolves ledger#325
kevinjfoley
force-pushed
the
report-delay-cmd-expansion
branch
from
0573def
to
7746467
Compare
Thanks! Anything else needed? I'm not sure what's wrong with the CI, I tried rebasing on the latest changes from master but it looks like it still isn't working. |
|
I think this PR breaks a couple things. For one thing, it causes the user to be re-prompted for any format specifiers that imply a prompt, such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delays the expansion of the report command until execution time. This leaves
the command in `ledger-report-cmd' unexpanded, which prevents the expanded
version of the command from being edited / saved by the user.
Resolves #325