CMake build does not generate QL_PACKAGE_NAME

[tom91136]

When using CMake, we get a define for PACKAGE_NAME instead of the QL_PACKAGE_NAME when using configure and make.
Looking at qt/Makefile.am, there's this intall-data-hook rule which rewrites a few things on install:

# ...
install-data-hook:
	$(SED) -e "s,HAVE_CONFIG_H,QL_HAVE_CONFIG_H," \
           -e "s,/\* install-hook \*/,#define QL_HAVE_CONFIG_H," \
           $(DESTDIR)$(this_includedir)/qldefines.hpp > .qldefines.hpp
	$(INSTALL_DATA) .qldefines.hpp $(DESTDIR)$(this_includedir)/qldefines.hpp
	rm .qldefines.hpp
	$(SED) -e "s,PACKAGE,QL_PACKAGE," \
           -e "s,STDC,QL_STDC," \
           -e "s, HAVE, QL_HAVE," \
           -e "s, VERSION, QL_AC_VERSION," \
           $(DESTDIR)$(this_includedir)/config.hpp > .config.hpp
	$(INSTALL_DATA) .config.hpp $(DESTDIR)$(this_includedir)/config.hpp
	rm .config.hpp
# ...

This logic isn't present in the CMake build.

There's a few libraries that depend on QL_PACKAGE_NAME (e.g https://github.com/eddelbuettel/rquantlib) so I think the CMake build should try to match that.

I'm happy to give this a stab, as the CMake build is also missing the pkg-config file generation logic that some libraries need.

[boring-cyborg]

Thanks for posting! It might take a while before we look at your issue, so don't worry if there seems to be no feedback. We'll get to it.

[tom91136]

Forgot to mention, I'm aware QL_VERSION exists in ql/version.hpp but since we have dependencies already using the undocumented one, I think it's best to keep both.

[lballabio]

Sure, go ahead. Thanks!

[github-actions]

This issue was automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in two weeks.

[github-actions]

This issue was automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in two weeks.