Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concerns #109

Open
johannesschobel opened this issue Apr 30, 2024 · 0 comments
Open

Concerns #109

johannesschobel opened this issue Apr 30, 2024 · 0 comments

Comments

@johannesschobel
Copy link

Dear @lazaronixon ,

thank you very much for this awesome library - i use it as replacement for "devise", and i really (!) like it.
However, i stumbled upon some issues, with respect to maintainability of my own code, when updating your library.

Every time i run rails g authentication --with-some-custom-arguments, my user.rb model is updated (i.e., all my changes are lost). I then need to manually accept / reject changes via console (i.e., to restore my previous functionality and add the required new features).

Therefore, i propose to move everything related to authentication-zero that is now within the User model (within app/models/user.rb) to a dedicated Authenticable concern (within app/models/concerns/authenticable.rb) and just include Authenticable in the User model.

I guess, i could do a PR, if you want - however, you may need to assist me, how to get your project running and tell me how i can test my changes.

All the best and thank you very much for your effort,
Johannes

This is similar to #106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant