perf: alias scanning in files #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld-kyee
reviewed
Nov 3, 2023
| @@ -0,0 +1 @@ | |||
| EVEN_WILDER = 'wildFlag' | |||
ld-kyee
approved these changes
Nov 3, 2023
mmrj
approved these changes
Nov 9, 2023
|
unfortunately the build is failing now that we're using re2, so i'm going to revert that change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of alias scanning in files in two ways
doublestar.FilepathGlob(glob)so that consecutive calls with same pattern can use resultsswap out golang regexp with https://github.com/wasilibs/go-re2With just change 1 I still found the tools running over 30 min (i stopped it before it finished) in one repo, but by adding change 2 it cut the time to under 10 min. Similarly, just implementing change 2 saw run times over 20 min (i stopped it before it finished).
This isn't a total fix for performance of scanning, depending on size of repo and wildcard patterns used, but it certainly helps.
UPDATE:
pulling back on the re2 usage since the build fails - we can revisit that later