Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ldignore file doesn't work for extinction searching #319

Open
rspechenkin opened this issue Jan 20, 2023 · 1 comment
Open

.ldignore file doesn't work for extinction searching #319

rspechenkin opened this issue Jan 20, 2023 · 1 comment
Labels
bug Something isn't working ignore files

Comments

@rspechenkin
Copy link

We have a GitHub repository with code written in Golang. We vendor all dependencies so there's a big vendor folder in the root of the repo that contains 3rd-party dependencies. We don't want to scan this folder so we have .ldignore file in the root of the repository. The content of this file is:

vendor/**

Despite this fact, if I make a commit and add new files to the vendor folder, I can see that the tool scans such files:

DEBUG: 2023/01/20 14:47:48 git.go:305: Examining from file: FROM_PATH and to file: vendor/test/test.md

It seems that it scans only files that were added in the commit but doesn't scan the files that were there before the commit. (we run the tool with --lookback 1 parameter to scan only the last commit)

Tool version: 2.8.0

@jazanne
Copy link
Contributor

jazanne commented Jan 23, 2023

Hi @rspechenkin thank you for submitting this ticket.

I would like to clarify that the logs that you are seeing here are for the extinctions phase of code reference scanning run, not the search for existing references. Unfortunately, there is a known issue that the extinctions phase doesn't respect the configured .ldignore file.

If you are not using extinctions you can set --lookback 0 to turn off the extinctions scan.

I am very sorry for the inconvenience. We will follow-up if there are any changes to this issue.

@jazanne jazanne added the bug Something isn't working label Jan 23, 2023
@jazanne jazanne linked a pull request Feb 16, 2023 that will close this issue
@jazanne jazanne removed a link to a pull request Feb 16, 2023
@jazanne jazanne changed the title .ldignore file doesn't work for newly added files .ldignore file doesn't work for extinction searching Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore files
Projects
None yet
Development

No branches or pull requests

2 participants