-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check only changed files #2
Comments
I tried to run it on the sbt/sbt repo and the current naive implementation (getting files content one by one) takes forever. Here's an idea of how this should work:
A simplified version to start with:
Other thoughts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current simple implementation just lists all files in the repo (at a given commit) and checks their formatting. This may take a long time in big repos. So the plan is to check only the files changed in the PR (i.e. assuming that
master
stays well-formatted).master
).scalafmt.conf
is among changed files, we still need to (re)check all filesThe text was updated successfully, but these errors were encountered: