Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hf.py from core model parser #1411

Open
rossdanlm opened this issue Mar 6, 2024 · 2 comments
Open

Remove hf.py from core model parser #1411

rossdanlm opened this issue Mar 6, 2024 · 2 comments

Comments

@rossdanlm
Copy link
Contributor

rossdanlm commented Mar 6, 2024

It is annoying, and we already gots the extension daaaaaaaawg

Also we should remove the HF dependencies and tests from core model parsers (move tests to the aiconfig/extensions/HuggingFace). You'll also have to remove it form the Config.py file where it gets registered

To test with local editor:

aiconfig_path=./cookbooks/Gradio/huggingface.aiconfig.json
parsers_path=./cookbooks/Gradio/aiconfig_model_registry.py
aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path
@justinkchen
Copy link
Contributor

I noticed the tests only seem to be in typescript? I don't see any tests currently for the hf.py file?

@rossdanlm
Copy link
Contributor Author

Oh damn my bad, could you remove from both Python and Typescript as well :P

I think this may have been why I didn't remove it quickly yet :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants