Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure default preferred media #260

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Configure default preferred media #260

merged 1 commit into from
Dec 1, 2023

Conversation

ouattararomuald
Copy link
Contributor

@ouattararomuald ouattararomuald commented Nov 30, 2023 •
edited

Fixes #76

Configurable default for TV shows vs Movies when searching

I've noticed that every time I click the search tab in my shiny new Nefarious instance, the Movies vs TV selection is always set to Movies. It's a little thing, but personally I'm looking for TV shows far more often than movies, and it would be nice to have an option in the settings to tell it to default to TV instead, so I don't have to remember to click it every time.

@lardbit
Copy link
Owner

lardbit commented Nov 30, 2023

You're officially the first code contributor! This project has been around for about 5 years. I'm pleased to see someone with typescript & django experience interested in this. Thanks. I'll review & test this PR within a week.

@lardbit lardbit self-assigned this Nov 30, 2023
@lardbit lardbit self-requested a review November 30, 2023 22:22
@lardbit lardbit mentioned this pull request Dec 1, 2023
Closed
@lardbit lardbit changed the base branch from master to feature/searching-default-settings December 1, 2023 22:08
@lardbit lardbit merged commit ae0e6e1 into lardbit:feature/searching-default-settings Dec 1, 2023
@lardbit lardbit mentioned this pull request Dec 1, 2023
Merged
@lardbit
Copy link
Owner

lardbit commented Dec 1, 2023

Thanks for the contribution, @ouattararomuald ! It's been merged into the main branch.

@ouattararomuald
Copy link
Contributor Author

Thanks a lot, @lardbit for the quick review! This is encouraging for other contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lardbit lardbit Awaiting requested review from lardbit

Assignees

@lardbit lardbit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Configurable default for TV shows vs Movies when searching
2 participants
@ouattararomuald @lardbit