Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scroll bar not automatically hidden when no text is out of bounds #2446

Closed
OTonGitHub opened this issue Jun 10, 2023 · 8 comments
Closed
Labels
A-ui Area: UI rendering and interactions C-bug Category: bug - something isn't working as it's supposed to good first issue Good for newcomers
Milestone

Comments

@OTonGitHub
Copy link

Lapce Version

0.2.8

System information

Windows 11

Describe the bug

In the code editor pan, if the lines do not exceed horizontal space available, the horizontal scroll bar does not appear, of course, once the line gets too long and get out of bounds, the bar appears, and you can scroll.
The issue is that, if for example you split the long line and stay in bound, the horizontal scroll bar still does not disappear, even though it is not needed. VSC has this behavior correctly, you will know for sure there is nothing left at the end of the line if this behavior is corrected to have the bar disappear once text is back in bound. If you restart the application the bar goes away, but it should have been gone automatically. This is not really a breaking bug, nor does it feel like a feature, something to fix, hope someone attends to this, I hope I have been clear, I have attached a video, I could tackle this myself too actually, if given the chance, thank you.

2023-06-10.09-28-29.mp4
@OTonGitHub OTonGitHub added the C-bug Category: bug - something isn't working as it's supposed to label Jun 10, 2023
@MinusGix MinusGix added good first issue Good for newcomers A-ui Area: UI rendering and interactions labels Jun 11, 2023
@weykon
Copy link

weykon commented Jul 1, 2023

#2496
I fixed this!
This is my first issue for lapce!

guys you can compare to above video with here.

2023-07-01.18.03.48.mov

@panekj
Copy link
Collaborator

panekj commented Jul 1, 2023

This issue is fixed in master already

@weykon
Copy link

weykon commented Jul 3, 2023

Oh, alright, that's good !

This issue is fixed in master already

@weykon
Copy link

weykon commented Jul 4, 2023

@OTonGitHub I think might be closed this issue

@OTonGitHub
Copy link
Author

I have built from masters and the horizontal scrollbar related issue does indeed seem to be fixed.
However some other features from 0.2.8 seems to not be in master or rather bugs present in master. Will open new issue for that.

Anyway, as mentioned, issue seems to be fixed, I will now send issue for closing.

@panekj
Copy link
Collaborator

panekj commented Jul 14, 2023

Will open new issue for that.

Please don't. #2417

@OTonGitHub
Copy link
Author

OTonGitHub commented Jul 14, 2023

gotcha, I missed the pin, have not actively checked repo in a while (is there actually another way to stay up to date on what's happening to Lapce? I know less platforms the better, just asking. I am new to git etc)

Some stuff seems to be missing in the task list in the migration task list. I will mention it as a comment in the pinned issue. How to actually contribute to this repo, just do pull request right? I found some very easy to fix (actual) bugs.

@panekj
Copy link
Collaborator

panekj commented Jul 14, 2023

we are most active on Discord, 2nd place would be here (GitHub Issues and Pull Requests), anywhere else it's mostly major news

@panekj panekj added this to the Next release milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Area: UI rendering and interactions C-bug Category: bug - something isn't working as it's supposed to good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants