Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Jina embeddings #973

Open
langchain4j opened this issue Apr 18, 2024 · 11 comments
Open

[FEATURE] Jina embeddings #973

langchain4j opened this issue Apr 18, 2024 · 11 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers P3 Medium priority

Comments

@langchain4j
Copy link
Owner

langchain4j commented Apr 18, 2024

Integrate Jina Embeddings as EmbeddingModel.

@langchain4j langchain4j added enhancement New feature or request good first issue Good for newcomers P3 Medium priority labels Apr 18, 2024
@lucifer-Hell
Copy link

Hi @langchain4j can you please assign this issue to me if some hasn't picked this already ?

@lucifer-Hell
Copy link

Hi @langchain4j , i have started working on integration . Is it okay if i follow AzureOpenAIEmbeddingModel as standard ref for building ?

@langchain4j
Copy link
Owner Author

Hey, Azure uses official SDK. I guess for Jina we will have to make our own client. Please take a look here:https://github.com/langchain4j/langchain4j/blob/main/CONTRIBUTING.md#guidelines-on-adding-a-new-embedding-store-integration

@lucifer-Hell
Copy link

Yes for jina ai currently python and javascript sdks are there only . So we have to build our own client . Thanks for sharing the guidelines i hv gone through that but the standard examples mentioned anthropic and chroma doesn't have any implementation of embedding model. I hv understanding but i just wanted to confirm if we hv to follow any standard ref/example for implementing Embedding Models .

@langchain4j
Copy link
Owner Author

Pardon, I mixed up embedding model and store :D
For EmbeddingModel implementation example, please check NomicEmbeddingModel

@lucifer-Hell
Copy link

Thanks for sharing we can add this point in contribute guideline doc also.

@lucifer-Hell
Copy link

Hi @langchain4j can you please review PR

@langchain4j
Copy link
Owner Author

Hi @lucifer-Hell thank you a lot! I will review it, in the order of priorities

@lucifer-Hell
Copy link

Hi @langchain4j just wanted know if u got the time to review it

@langchain4j
Copy link
Owner Author

@lucifer-Hell unfortunately not yet

One16-KS pushed a commit to One16-KS/langchain4j that referenced this issue May 3, 2024
Module added according langchain4j#973 in order to minimize conflicts.
Implementation in line with cohere reranking
@lucifer-Hell
Copy link

Hi @langchain4j just checking on this issue . If your bandwidth is less you may assign someone else as reviewer if its possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P3 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants