Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add name to dev.langchain4j.rag.content.retriever.EmbeddingStoreContentRetriever to improve logs #972

Open
alwa opened this issue Apr 18, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers P3 Medium priority

Comments

@alwa
Copy link

alwa commented Apr 18, 2024

Is your feature request related to a problem? Please describe.
Log messages today are not very nice when using multiple retrievers (to see which one is used):

2024-04-18T19:19:18.931+02:00 DEBUG 62320 --- [pool-2-thread-1] d.l.rag.DefaultRetrievalAugmentor : Routing query '' to the following retriever: dev.langchain4j.rag.content.retriever.EmbeddingStoreContentRetriever@965f916

Describe the solution you'd like

  1. Add name property to EmbeddingStoreContentRetriever
  2. Implement EmbeddingStoreContentRetriever.toString() and use the name property in that implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P3 Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants