New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Pinecone should support storing metadata #435
Labels
Comments
See #437 for a fix suggestion |
langchain4j
changed the title
[BUG] Pinecone doesn't add metadata to request
[FEATURE] Pinecone should support storing metadata
Apr 11, 2024
langchain4j
added
enhancement
New feature or request
P2
High priority
and removed
bug
Something isn't working
labels
Apr 11, 2024
rgrebski
pushed a commit
to Stepwisepl/langchain4j
that referenced
this issue
Apr 17, 2024
Created PR #955 for that issue. Btw - If we manage to get this merged soon - I have already done the upgrade from pinecone-client 0.6.0 to 1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Please provide as much details as possible, this will help us to deliver a fix as soon as possible.
Thank you!
Describe the bug
A clear and concise description of what the bug is.
PineconeEmbeddingStore
, the Pinecone implementation ofEmbedding
store, is aTextSegment
embeddings store. Since the latter has aMetadata
attribute, it stands to reason that if a client called theadd
method using TextSegments with metadata, that the metadata would be uploaded to Pinecone. The actual behavior is that the Metadata gets dropped.Log and Stack trace
Please provide a log and a stack trace (with exception), if applicable.
N/A
To Reproduce
Please provide a relevant code snippets to reproduce this bug.
(excuse my Java, I am a Clojure programmer)
Expected behavior
A clear and concise description of what you expected to happen.
Expecting the metadata to appear in the Pinecone console/be retrieved with Query requests
Please complete the following information:
Additional context
Add any other context about the problem here.
This appears to be just omitted from the interaction with Pinecone:
langchain4j/langchain4j-pinecone/src/main/java/dev/langchain4j/store/embedding/pinecone/PineconeEmbeddingStore.java
Line 135 in e2ba220
I may try to make a pull request. In the meantime I will have to write my own Pinecone integration with their SDK.
The text was updated successfully, but these errors were encountered: