Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol/Smtp/Auth classes have different signature than parent class #160

Open
rarog opened this issue Jul 9, 2021 · 0 comments
Open
Labels
Bug Something isn't working

Comments

@rarog
Copy link

rarog commented Jul 9, 2021

Bug Report

Q A
Version(s) 2.14.1

Summary

All classes in Protocol/Smtp/Auth have less strict signature than parent class without profiting from it.

Current behavior

Current signature is public function __construct($host = '127.0.0.1', $port = null, $config = null) while Protocol/Smtp has the signature public function __construct($host = '127.0.0.1', $port = null, array $config = null).
As the original parameter is passed on as is to the parent class, $config should also be forced to be of type array to match and enforce correctness.

@rarog rarog added the Bug Something isn't working label Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant