Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly isolate #[allow(clippy::..)] to generated code #769

Open
youknowone opened this issue Apr 23, 2023 · 1 comment
Open

properly isolate #[allow(clippy::..)] to generated code #769

youknowone opened this issue Apr 23, 2023 · 1 comment

Comments

@youknowone
Copy link
Contributor

see #739 (comment)

@dburgener
Copy link
Contributor

I attempted to address this with #784, which followed the suggestion linked above. The issue pointed out in that PR review, is that adding the layer of indirection on the non-action portions doesn't really accomplish much, since each pub parser is in its own module anyways.

It may be more desirable to add any needed clippy exceptions directly on the parse mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants