-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility behavior of changing the out_dir is incredibly confusing #699
Milestone
Comments
@nikomatsakis do you have any idea about this issue? |
I don't remember much of the details here but I definitely think we should clean this up for 1.0. I was trying it out on a recent project and I also hit some issues with a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was just getting incredibly confused why
lalrpop::Configuration().set_out_dir("out").process_current_dir()
wrote the.rs
file to the current directory instead of theout/
directory. I looked through the documentation and couldn't find any answer, I looked through theapi/mod.rs
source code and couldn't find any answer. Only when digging deeper into the source code I found the following:lalrpop/lalrpop/src/build/mod.rs
Lines 91 to 96 in b777a6a
And
process_current_dir
apparently sets the in_dir to./src
triggering this "compatibility" behavior.This is so incredibly unintuitive that I think that behavior should either be removed or the
Configuration
API be deprecated in favor of something more sane.The text was updated successfully, but these errors were encountered: