Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot bind key to fzf's history search #23

Open
halloleo opened this issue Feb 11, 2022 · 3 comments
Open

Cannot bind key to fzf's history search #23

halloleo opened this issue Feb 11, 2022 · 3 comments

Comments

@halloleo
Copy link

When I set

$fzf_history_binding = "c-r"

and I type Ctrl-R still the normal xonsh backward search comes up.

Is this a compatebilty issue? Here all the steps I have done:

  1. I have installed fzf. It is now on my path: Typing fzf opens the fzf selector.
  2. I install the xontrib-fzf-widgets extension via xpip install xontrib-fzf-widgets.
  3. I load the extension via xontrib load xontrib-fzf-widgets.
  4. I issue in my xonsh shell $fzf_history_binding = "c-r".
  5. I type Ctrl-r.

And here the versions involved:

module version
xonsh 0.11.0
xontrib-fzf-widgets 0.0.4
fzf 0.29.0 (brew)
@halloleo
Copy link
Author

Just found out what's the problem: I have to set $fzf_history_binding = "c-r" first and then load the xontrib!!!

Is this something which can be fixed? If not I'm happy to update the README to make users aware of the requested order.

@laloch
Copy link
Owner

laloch commented Feb 16, 2022

Hi @halloleo, sorry for the delay. I will probably abandon and archive (or just abandon) this project. I'm not happy with the direction the OSS community has decided to take and I chose not to participate and contribute anymore.

@halloleo
Copy link
Author

Thanks for the info, @laloch! Fair enough if you want to abandon the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants