Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend more than one 'other' language #30

Open
HyunggyuJang opened this issue Feb 20, 2021 · 2 comments
Open

Extend more than one 'other' language #30

HyunggyuJang opened this issue Feb 20, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@HyunggyuJang
Copy link

Hi, I appreciate your work! It really made writing routines straightforward.
However, I'd like to extend your package to support more than one other language. Your implementation is useful as it is, but I started to imagine how less cumbersome my life is going to be if I don't ever press input source change command in macOS. As you know, macOS has some issues about CJKV input methods, and I'm using two of them in my workflow -- English, Korean, Japanese.
With your contribution, I was able to get rid of pressing input source changing command to Korean. Now I hope I'm able to do so for Japanese.

Again, thanks for this great work!

@laishulu laishulu added the enhancement New feature or request label Feb 20, 2021
@laishulu
Copy link
Owner

I have not considering this scenario from the beginning,
but it's possible although nontrivial.

@HyunggyuJang
Copy link
Author

Yeah, I was tinkering over this for a while. However, as soon as I saw the code, I realized it would be a major change in code base and even if I have done it correctly, my work would break once you upgrade this package. Furthermore, I assume you have your own taste and philosophy on coding and mine might be not in line with yours. So I thought it would be more wise to open an issue hoping you can give it a thought.

Thanks for your attention! Once it has done, this improvement will alleviate a lot of burden for people like me out there who have to press input source toggling commands several times and even have to inspect what the current source is to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants