Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: labring/calico CMD delete -f chart.values.yaml #4543

Open
wisheen opened this issue Mar 1, 2024 · 1 comment
Open

Feature: labring/calico CMD delete -f chart.values.yaml #4543

wisheen opened this issue Mar 1, 2024 · 1 comment
Labels
kind/feature New feature or request

Comments

@wisheen
Copy link
Contributor

wisheen commented Mar 1, 2024

What is the problem this feature will solve?

chart.values.yaml generate by init.sh, helm upgrade -i -f chart.values.yaml will be overriding charts/calico/values.yaml. If you want to customize Clusterfile file, it will not take effect.

---
apiVersion: apps.sealos.io/v1beta1
kind: Config
metadata:
  creationTimestamp: null
  name: calico
spec:
  data: |
    installation:
      enabled: true
      kubernetesProvider: ""
      calicoNetwork:
        nodeAddressAutodetectionV4:
          interface: "eth0"
  path: charts/calico/values.yaml
  strategy: merge

If you have solution,please describe it

  1. calico default value firstFound maybe better
  2. delete helm -f chart.values.yaml
  3. If change the default value is best directly modify charts/calico/values.yml in kubeimage

What alternatives have you considered?

No response

@wisheen wisheen added the kind/feature New feature or request label Mar 1, 2024
@willzhang
Copy link
Contributor

willzhang commented Apr 21, 2024

Here maybe help:

https://github.com/labring-actions/cluster-image/tree/main/applications/calico#configuration

It is charts/calico.values.yaml

https://github.com/labring-actions/cluster-image/blob/main/applications/calico/latest/Kubefile

CMD ["helm upgrade -i $(NAME) charts/calico -f charts/calico.values.yaml -n $(NAMESPACE) --create-namespace $(HELM_OPTS)"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants