-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about value_pe #251
Comments
Thanks. It's a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the file, rope/value_pe/init.py
It seems the value embedding is rotated twice in line 230 and line 234.
From my understanding, only one rotation is enough.
Please let me know whether I misunderstood this.
Thanks.
The text was updated successfully, but these errors were encountered: