-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] RMSNorm Implementation #180
Labels
Comments
Hello there, thank you for opening an Issue ! 🙏🏻 The team was notified and they will get back to you asap. |
Stale issue message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think you should be dividing by the scale in the following line
zeta/zeta/nn/modules/rms_norm.py
Line 35 in 7dbb6a6
This this the scale definition
https://github.com/kyegomez/zeta/blob/7dbb6a62f83413977a922d5fc6dec1b11f734bc3/zeta/nn/modules/rms_norm.py#L29C9-L29C31
And RMSNorm formula
Edit:
Also, I think the normalization should be in the dim -1, not -2
zeta/zeta/nn/modules/rms_norm.py
Line 34 in 7dbb6a6
Upvote & Fund
The text was updated successfully, but these errors were encountered: