Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Read-only Transaction check to function calls #3502

Open
yiyun-sj opened this issue May 15, 2024 · 1 comment
Open

Add Read-only Transaction check to function calls #3502

yiyun-sj opened this issue May 15, 2024 · 1 comment
Assignees

Comments

@yiyun-sj
Copy link
Collaborator

At client_context.cpp:320-331 we check if a statement would be a valid read-only statement for read-only transactions. However, the expressions within the statements could contain functions that could perform a write. We currently don't check this. As well, we don't seem to check if macro functions are read-only either. We perhaps want to handle this in the binding stage instead of the parser stage as above.

@ray6080
Copy link
Contributor

ray6080 commented May 15, 2024

We should introduce a more scalable infrastructure to track if a statement/expression/function is modifying the database or not (perhaps during binder phase). @andyfengHKU or @acquamarin should take a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants