Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoind rpc thread in production #636

Open
yanganto opened this issue Sep 11, 2023 · 0 comments
Open

Bitcoind rpc thread in production #636

yanganto opened this issue Sep 11, 2023 · 0 comments
Labels

Comments

@yanganto
Copy link
Collaborator

The bitcoind service and kld service should be one to one.

The send_transaction is defined here, but nowhere using it now. And it clones the client and also causes a lot of upstream structure to wrap with Arc
https://github.com/kuutamolabs/lightning-knd/blob/bf5ade093a0baa164dd37a93c794ef2924f2fab4/kld/src/bitcoind/bitcoind_client.rs#L78-L81

Is there a possible kld need to have multiple queries on bitcoind at the same time?

  • If there is always one query at the same time, why do we just use the reference of the client?
  • If it is possible but rare, why not make a lock on the client?
  • If it is possible and often why not make a queue or suitable channel for the transactions? Such that when the request reaches the concurrent limitation we can handle it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants