Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rate limit #27

Open
ghost opened this issue May 15, 2020 · 5 comments
Open

feat: Rate limit #27

ghost opened this issue May 15, 2020 · 5 comments
Labels
💬 Discussion Needs to be discussed 💚 Enhancement Suggestion for improval

Comments

@ghost
Copy link

ghost commented May 15, 2020

Some ISP prevents you from sending so many mails in a given window of time.

I think it would be good for those to have a way to limit the mail per hour or something.

@ghost ghost changed the title feat: Add support for rate limit feat: Rate limit May 15, 2020
@kumarabhirup kumarabhirup added 💚 Enhancement Suggestion for improval 💬 Discussion Needs to be discussed labels May 15, 2020
@kumarabhirup
Copy link
Owner

Users can adjust to rate limiting requirements
by adjusting the time interval cron job setting to fit their needs.

But yes, this feature would be a nice addition. Your thoughts?

@ghost
Copy link
Author

ghost commented May 15, 2020

I might have something to suggest but I'm not sure if that's good enough

{
  interval: (1000 * 60) * 60,
  rate: 25
}

25 mails every hour.

Or maybe something that would enforce the cron to avoid having too many mails being sent and blocking the ISP...

@kumarabhirup
Copy link
Owner

Wow, this looks promising. I would like to add this feature.

Just wondering, are you a Node.js dev? If yes, we can add this simple feature together.

If not, I will do it myself but will take time most probably.

@ghost
Copy link
Author

ghost commented May 15, 2020

I did not get a chance to look at the source code yet but I have some experience using Node.js even though my thing is more DOM API and front end related stuff ^^

@kumarabhirup
Copy link
Owner

That's cool! You can take a look at the source code for a while, till then I'll think about how this feature can be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 Discussion Needs to be discussed 💚 Enhancement Suggestion for improval
Projects
None yet
Development

No branches or pull requests

1 participant