Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize the constants #275

Open
gary-lgy opened this issue Nov 17, 2023 · 0 comments
Open

Organize the constants #275

gary-lgy opened this issue Nov 17, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@gary-lgy
Copy link
Member

Currently constants are defined in a couple of places:

  • pkg/controllers/common/constants.go
  • controller's own package
  • pkg/util packages

We should organize them so they are more maintainable. When organizing, we should make sure:

  • the constants are exposed to all packages in the project and not just for pkg/controllers
  • the constants are categorized properly
  • unused constants should be removed
@gary-lgy gary-lgy added the good first issue Good for newcomers label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gary-lgy